parser: suggest quotes only for ident attribute values #124512
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot
added
S-waiting-on-review
|
r? diagnostics |
|
This needs a test @rustbot author |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-author
ohno418
force-pushed
the
improve-suggesting-attr-val
branch
from
ef15235 to
ea04951
Compare
When encountering code like:
```
#[cfg(key = ["foo", "bar"])]
fn main() {}
```
the parser incorrectly suggests:
```
error: expected unsuffixed literal, found `[`
--> ../pg/src/main.rs:1:13
|
1 | #[cfg(key = ["foo", "bar"])]
| ^
|
help: surround the identifier with quotation marks to parse it as a string
|
1 | #[cfg(key =" "["foo", "bar"])]
| + +
error: aborting due to 1 previous error
```
This commit modifies the parser to check if an attribute value is an
ident before suggesting.
|
Added a test. @compiler-errors |
|
Could not assign reviewer from: |
|
☔ The latest upstream changes (presumably #124972) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing as this has been fixed by 0ad3c5d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering code like:
the parser incorrectly suggests:
This commit modifies the parser to check if an attribute value is an ident before suggesting.